WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
178282
Web Inspector: send a DOM node with each Canvas payload and eliminate Canvas.requestNode
https://bugs.webkit.org/show_bug.cgi?id=178282
Summary
Web Inspector: send a DOM node with each Canvas payload and eliminate Canvas....
Devin Rousso
Reported
2017-10-13 13:30:28 PDT
All the UI that relates to Canvas uses the canvas' node. We currently get the node via a protocol method, but since we always need the node in the UI, we might as well save a trip and just include the nodeId in the Canvas payload. Doing this will eliminate the need for Canvas.requestNode.
Attachments
[Patch] WIP
(42.38 KB, patch)
2017-12-04 17:05 PST
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2017-12-04 16:40:08 PST
<
rdar://problem/35842976
>
Devin Rousso
Comment 2
2017-12-04 17:05:35 PST
Created
attachment 328416
[details]
[Patch] WIP I probably should've uploaded this earlier, but I tried doing some of this at the WebKit Contributors Meeting. I kept running into an issue with how the document is fetched by the frontend, and how in doing so it would clear all the previously retrieved IDs, meaning that any we sent to the frontend for the Canvases would effectively be wiped out.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug