WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED CONFIGURATION CHANGED
184796
[Web Animations] Fix leaks and turn back on by default
https://bugs.webkit.org/show_bug.cgi?id=184796
Summary
[Web Animations] Fix leaks and turn back on by default
Antoine Quint
Reported
2018-04-19 15:09:53 PDT
[Web Animations] Fix leaks and turn back on by default
Attachments
Patch
(56.97 KB, patch)
2018-04-19 15:10 PDT
,
Antoine Quint
no flags
Details
Formatted Diff
Diff
WIP
(64.74 KB, patch)
2018-04-19 15:21 PDT
,
Jon Lee
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews102 for mac-sierra
(2.86 MB, application/zip)
2018-04-19 16:20 PDT
,
EWS Watchlist
no flags
Details
Archive of layout-test-results from ews121 for ios-simulator-wk2
(12.63 MB, application/zip)
2018-04-19 16:51 PDT
,
EWS Watchlist
no flags
Details
Archive of layout-test-results from ews106 for mac-sierra-wk2
(3.12 MB, application/zip)
2018-04-19 17:05 PDT
,
EWS Watchlist
no flags
Details
Archive of layout-test-results from ews115 for mac-sierra
(3.14 MB, application/zip)
2018-04-19 17:20 PDT
,
EWS Watchlist
no flags
Details
Patch
(253.29 KB, patch)
2018-04-20 03:46 PDT
,
Antoine Quint
no flags
Details
Formatted Diff
Diff
Patch
(254.09 KB, patch)
2018-04-20 05:56 PDT
,
Antoine Quint
ews-watchlist
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from ews100 for mac-sierra
(2.32 MB, application/zip)
2018-04-20 06:52 PDT
,
EWS Watchlist
no flags
Details
Archive of layout-test-results from ews106 for mac-sierra-wk2
(2.65 MB, application/zip)
2018-04-20 07:23 PDT
,
EWS Watchlist
no flags
Details
Archive of layout-test-results from ews122 for ios-simulator-wk2
(2.17 MB, application/zip)
2018-04-20 07:34 PDT
,
EWS Watchlist
no flags
Details
Archive of layout-test-results from ews113 for mac-sierra
(3.78 MB, application/zip)
2018-04-20 07:37 PDT
,
EWS Watchlist
no flags
Details
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Antoine Quint
Comment 1
2018-04-19 15:10:20 PDT
Created
attachment 338366
[details]
Patch
Jon Lee
Comment 2
2018-04-19 15:21:50 PDT
Created
attachment 338368
[details]
WIP
EWS Watchlist
Comment 3
2018-04-19 15:24:08 PDT
Attachment 338368
[details]
did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 43 files If any of these errors are false positives, please file a bug against check-webkit-style.
EWS Watchlist
Comment 4
2018-04-19 16:20:13 PDT
Comment on
attachment 338368
[details]
WIP
Attachment 338368
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.webkit.org/results/7376181
New failing tests: imported/w3c/web-platform-tests/web-animations/timing-model/animations/playing-an-animation.html imported/w3c/web-platform-tests/web-animations/timing-model/animations/reversing-an-animation.html imported/w3c/web-platform-tests/web-animations/interfaces/Animation/ready.html animations/fill-mode-removed.html imported/mozilla/css-transitions/test_event-dispatch.html webanimations/css-transitions.html
EWS Watchlist
Comment 5
2018-04-19 16:20:15 PDT
Created
attachment 338376
[details]
Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 6
2018-04-19 16:51:20 PDT
Comment on
attachment 338368
[details]
WIP
Attachment 338368
[details]
did not pass ios-sim-ews (ios-simulator-wk2): Output:
http://webkit-queues.webkit.org/results/7376261
New failing tests: imported/w3c/web-platform-tests/web-animations/timing-model/animations/playing-an-animation.html imported/w3c/web-platform-tests/web-animations/timing-model/animations/reversing-an-animation.html imported/w3c/web-platform-tests/web-animations/interfaces/Animation/ready.html animations/fill-mode-removed.html imported/mozilla/css-transitions/test_event-dispatch.html webanimations/css-transitions.html
EWS Watchlist
Comment 7
2018-04-19 16:51:22 PDT
Created
attachment 338380
[details]
Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
EWS Watchlist
Comment 8
2018-04-19 17:05:41 PDT
Comment on
attachment 338368
[details]
WIP
Attachment 338368
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.webkit.org/results/7376668
New failing tests: imported/w3c/web-platform-tests/web-animations/timing-model/animations/playing-an-animation.html imported/w3c/web-platform-tests/web-animations/timing-model/animations/reversing-an-animation.html imported/w3c/web-platform-tests/web-animations/interfaces/Animation/ready.html animations/fill-mode-removed.html imported/mozilla/css-transitions/test_event-dispatch.html webanimations/css-transitions.html
EWS Watchlist
Comment 9
2018-04-19 17:05:43 PDT
Created
attachment 338382
[details]
Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 10
2018-04-19 17:20:57 PDT
Comment on
attachment 338368
[details]
WIP
Attachment 338368
[details]
did not pass mac-debug-ews (mac): Output:
http://webkit-queues.webkit.org/results/7376559
New failing tests: imported/w3c/web-platform-tests/web-animations/timing-model/animations/playing-an-animation.html imported/w3c/web-platform-tests/web-animations/timing-model/animations/reversing-an-animation.html imported/w3c/web-platform-tests/web-animations/interfaces/Animation/ready.html animations/fill-mode-removed.html imported/mozilla/css-transitions/test_event-dispatch.html webanimations/css-transitions.html
EWS Watchlist
Comment 11
2018-04-19 17:20:58 PDT
Created
attachment 338384
[details]
Archive of layout-test-results from ews115 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6
Antoine Quint
Comment 12
2018-04-20 03:46:03 PDT
Created
attachment 338405
[details]
Patch
Antoine Quint
Comment 13
2018-04-20 05:56:08 PDT
Created
attachment 338414
[details]
Patch
EWS Watchlist
Comment 14
2018-04-20 05:59:24 PDT
Attachment 338414
[details]
did not pass style-queue: ERROR: Source/WebKitLegacy/win/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 287 files If any of these errors are false positives, please file a bug against check-webkit-style.
EWS Watchlist
Comment 15
2018-04-20 06:52:47 PDT
Comment on
attachment 338414
[details]
Patch
Attachment 338414
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.webkit.org/results/7382873
New failing tests: imported/mozilla/css-transitions/test_event-dispatch.html
EWS Watchlist
Comment 16
2018-04-20 06:52:49 PDT
Created
attachment 338421
[details]
Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 17
2018-04-20 07:23:43 PDT
Comment on
attachment 338414
[details]
Patch
Attachment 338414
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.webkit.org/results/7383082
New failing tests: imported/mozilla/css-transitions/test_event-dispatch.html
EWS Watchlist
Comment 18
2018-04-20 07:23:45 PDT
Created
attachment 338423
[details]
Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 19
2018-04-20 07:34:47 PDT
Comment on
attachment 338414
[details]
Patch
Attachment 338414
[details]
did not pass ios-sim-ews (ios-simulator-wk2): Output:
http://webkit-queues.webkit.org/results/7382986
New failing tests: imported/mozilla/css-transitions/test_event-dispatch.html
EWS Watchlist
Comment 20
2018-04-20 07:34:49 PDT
Created
attachment 338425
[details]
Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
EWS Watchlist
Comment 21
2018-04-20 07:37:40 PDT
Comment on
attachment 338414
[details]
Patch
Attachment 338414
[details]
did not pass mac-debug-ews (mac): Output:
http://webkit-queues.webkit.org/results/7382992
New failing tests: animations/change-completed-animation-transform.html media/video-play-require-user-gesture.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgba4444.html animations/fill-forwards-auto-height.html fast/canvas/webgl/oes-texture-half-float.html animations/state-at-end-event.html media/video-currentTime-set.html animations/play-state-start-paused.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html compositing/transitions/scale-transition-no-start.html
EWS Watchlist
Comment 22
2018-04-20 07:37:41 PDT
Created
attachment 338426
[details]
Archive of layout-test-results from ews113 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-sierra Platform: Mac OS X 10.12.6
Alex Christensen
Comment 23
2021-11-01 12:05:41 PDT
Comment on
attachment 338414
[details]
Patch This has been requesting review for more than one year. If this is still needed, please rebase and re-request review.
Antoine Quint
Comment 24
2022-01-12 12:07:46 PST
Web Animations have been turned back on by default a long time ago already.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug