CLOSED FIXED194587
[GTK][WPE] Don't use DumpJSConsoleLogInStdErr expectation in platform TestExpectations 
https://bugs.webkit.org/show_bug.cgi?id=194587
Summary [GTK][WPE] Don't use DumpJSConsoleLogInStdErr expectation in platform TestExp...
Fujii Hironori
Reported 2019-02-13 00:24:42 PST
[GTK][WPE] Don't use DumpJSConsoleLogInStdErr expectation in platform TestExpectations This is a sub task of Bug 194586. I'd like to eliminate DumpJSConsoleLogInStdErr expectation in platform TestExpectations in order to use dumpJSConsoleLogInStdErr=true webkit-test-runner option. > <!-- webkit-test-runner [ dumpJSConsoleLogInStdErr=true ] -->
Attachments
Patch (2.99 KB, patch)
2019-02-13 01:09 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Claudio Saavedra
Comment 1 2019-02-13 00:45:29 PST
I see that your patch in bug 194283 already takes care of this. What else is needed?
Fujii Hironori
Comment 2 2019-02-13 01:06:33 PST
(In reply to Claudio Saavedra from comment #1) > I see that your patch in bug 194283 already takes care of this. What else is > needed? DumpJSConsoleLogInStdErr expectation is considered a bad idea by some devs. And, we have dumpJSConsoleLogInStdErr test option now (Bug 177027). So, I'd like to remove DumpJSConsoleLogInStdErr expectation and use dumpJSConsoleLogInStdErr test option instead. (In reply to Jonathan Bedard from bug #194283 comment #3) > This bug very much confuses me. Why would we have a test expectation with > DumpJSConsoleLogInStdErr in it? That feels like an abuse of the > TestExpectations. (In reply to Alexey Proskuryakov from bug #194283 comment #2) > I think that we are hitting a design mistake with regards to > DumpJSConsoleLogInStdErr - it is not an expectation, so mixing it with > expectations causes trouble. (In reply to youenn fablet from bug #161310 comment #4) > It seems a bit odd to add that keyword to TestExpectations since it is > becoming more like a setup option. This applies also a bit to Slow keyword.
Fujii Hironori
Comment 3 2019-02-13 01:09:22 PST
Created attachment 361904 [details] Patch
Fujii Hironori
Comment 4 2019-02-13 01:30:01 PST
I confirmed this change doesn't affect the output of following commands. I believe this patch changes nothing. ./Tools/Scripts/webkit-patch print-expectations --port=wpe http/tests/appcache ./Tools/Scripts/webkit-patch print-expectations --port=gtk http/tests/appcache
Fujii Hironori
Comment 5 2019-02-13 02:12:53 PST
Committed r241430: <https://trac.webkit.org/changeset/241430>
Radar WebKit Bug Importer
Comment 6 2019-02-13 02:13:30 PST
<rdar://problem/48032550>
Note You need to log in before you can comment on or make changes to this bug.