214381 – Added Fixes for AudioScheduledSourceNode

Clark Wang

Reported 2020-07-15 15:32:16 PDT

Added in IDL file for AudioScheduledSourceNode and other fixes for this interface. Added in ConstantSourceOptions files. Removed unrestricted keyword from attributes in BaseAudioContext.idl to match spec.

Clark Wang

Comment 1 2020-07-15 15:45:48 PDT

Created attachment 404401 [details] Patch

Clark Wang

Comment 2 2020-07-16 07:27:09 PDT

Created attachment 404438 [details] Patch

Chris Dumez

Comment 3 2020-07-16 08:22:33 PDT

Comment on attachment 404438 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404438&action=review > Source/WebCore/ChangeLog:9 > + Added in ConstantSourceOptions files. Removed unrestricted keyword from attributes in Please do not put unrelated changes in a single patch.

Clark Wang

Comment 4 2020-07-16 08:44:32 PDT

Ok, let me split up these changes into separate patches. Thanks!

Clark Wang

Comment 5 2020-07-16 09:31:15 PDT

Created attachment 404450 [details] Patch

Chris Dumez

Comment 6 2020-07-16 09:38:24 PDT

Comment on attachment 404450 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404450&action=review > Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl:29 > ActiveDOMObject, You should be able to drop this now. > Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl:30 > +] interface AudioBufferSourceNode : AudioScheduledSourceNode { Well, then you'd want to drop start() / stop() / onended from this interface.. > Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp:139 > +ExceptionOr<void> AudioScheduledSourceNode::startLater(Optional<double> optionalWhen) That's wrong. There is already a default value of 0 in the IDL so the generated bindings will always give you a double. > Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp:159 > +ExceptionOr<void> AudioScheduledSourceNode::stopLater(Optional<double> optionalWhen) Ditto. > Source/WebCore/Modules/webaudio/OscillatorNode.idl:37 > ActiveDOMObject, You should be able to drop this now. > Source/WebCore/Modules/webaudio/OscillatorNode.idl:38 > +] interface OscillatorNode : AudioScheduledSourceNode { Well, then you'd want to drop start() / stop() / onended from this interface..

Chris Dumez

Comment 7 2020-07-16 09:38:29 PDT

Comment on attachment 404450 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404450&action=review > Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl:29 > ActiveDOMObject, You should be able to drop this now. > Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl:30 > +] interface AudioBufferSourceNode : AudioScheduledSourceNode { Well, then you'd want to drop start() / stop() / onended from this interface.. > Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp:139 > +ExceptionOr<void> AudioScheduledSourceNode::startLater(Optional<double> optionalWhen) That's wrong. There is already a default value of 0 in the IDL so the generated bindings will always give you a double. > Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp:159 > +ExceptionOr<void> AudioScheduledSourceNode::stopLater(Optional<double> optionalWhen) Ditto. > Source/WebCore/Modules/webaudio/OscillatorNode.idl:37 > ActiveDOMObject, You should be able to drop this now. > Source/WebCore/Modules/webaudio/OscillatorNode.idl:38 > +] interface OscillatorNode : AudioScheduledSourceNode { Well, then you'd want to drop start() / stop() / onended from this interface..

Clark Wang

Comment 8 2020-07-16 15:23:36 PDT

Created attachment 404486 [details] Patch

Clark Wang

Comment 9 2020-07-17 11:17:11 PDT

Created attachment 404576 [details] Patch

EWS

Comment 10 2020-07-17 15:18:10 PDT

Committed r264538: <https://trac.webkit.org/changeset/264538> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404576 [details].

Radar WebKit Bug Importer

Comment 11 2020-07-17 15:19:17 PDT

<rdar://problem/65746671>

Attachments
Patch (38.70 KB, patch) 2020-07-15 15:45 PDT, Clark Wang	no flags	Details Formatted Diff Diff
Patch (38.70 KB, patch) 2020-07-16 07:27 PDT, Clark Wang	no flags	Details Formatted Diff Diff
Patch (21.77 KB, patch) 2020-07-16 09:31 PDT, Clark Wang	no flags	Details Formatted Diff Diff
Patch (33.74 KB, patch) 2020-07-16 15:23 PDT, Clark Wang	no flags	Details Formatted Diff Diff
Patch (33.93 KB, patch) 2020-07-17 11:17 PDT, Clark Wang	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.