RESOLVED FIXED215949
[ews] Notify bot watchers about pre-existing and flaky test failures for API tests 
https://bugs.webkit.org/show_bug.cgi?id=215949
Summary [ews] Notify bot watchers about pre-existing and flaky test failures for API ...
Aakash Jain
Reported 2020-08-28 13:34:35 PDT
Notify bot watchers about pre-existing and flaky test failures for API tests found in EWS.
Attachments
Patch (3.92 KB, patch)
2020-09-04 04:36 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-09-04 04:36:45 PDT
Created attachment 407957 [details] Patch
Jonathan Bedard
Comment 2 2020-09-04 11:18:04 PDT
Comment on attachment 407957 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407957&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:2606 > + def send_email_for_flaky_failure(self, test_name): I'm find with this as-is, but it does seem like we're duplicating quite a bit of code for layout test emails. Seems like we might want a base "AnalyzeTestResults" step with a "send_email_for_flaky_failure(self, test_name):" function that pulls from a "suite" variable
Aakash Jain
Comment 3 2020-09-04 11:43:35 PDT
Yeah, will do that in a separate patch.
EWS
Comment 4 2020-09-04 11:51:03 PDT
Committed r266626: <https://trac.webkit.org/changeset/266626> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407957 [details].
Radar WebKit Bug Importer
Comment 5 2020-09-04 11:52:19 PDT
<rdar://problem/68358168>
Note You need to log in before you can comment on or make changes to this bug.