REOPENED218579
[Interop 2021][css-flexbox] flex item margins not included in flex container overflow 
https://bugs.webkit.org/show_bug.cgi?id=218579
Summary [Interop 2021][css-flexbox] flex item margins not included in flex container ...
fantasai
Reported 2020-11-04 11:51:49 PST
Spec requires flex item margins (and the flex container's padding) to be included in the flex container's overflow area. This is tested in https://wpt.fyi/results/css/css-flexbox/overflow-area-001.html?label=experimental&label=master&aligned https://wpt.fyi/results/css/css-flexbox/overflow-area-002.html?label=experimental&label=master&aligned and it definitely bugs authors. (The spec bugs about including margins/padding were some of the most flagged issues in the CSSWG repo.)
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-11-04 12:08:26 PST
<rdar://problem/71046552>
Tim Nguyen (:ntim)
Comment 2 2022-10-05 20:50:09 PDT
if (isGridItem()) { // As per https://github.com/w3c/csswg-drafts/issues/3653, child's margins should contribute to the scrollable overflow area. // FIXME: Expand it to non-grid cases when applicable. rect.setWidth(rect.width() + std::max(0_lu, marginEnd())); } in RenderBox::layoutOverflowRectForPropagation is a good first place to look at.
fantasai
Comment 3 2025-10-16 12:22:43 PDT
Pull request: https://github.com/WebKit/WebKit/pull/52498
EWS
Comment 4 2025-10-20 10:12:13 PDT
Committed 301814@main (37c111e7fc47): <https://commits.webkit.org/301814@main> Reviewed commits have been landed. Closing PR #52498 and removing active labels.
EWS
Comment 5 2025-10-20 12:16:44 PDT
Committed 301765.29@safari-7623-branch (c274d802a94c): <https://commits.webkit.org/301765.29@safari-7623-branch> Reviewed commits have been landed. Closing PR #3808 and removing active labels.
Karl Dubost
Comment 6 2025-10-26 23:15:04 PDT
*** Bug 258354 has been marked as a duplicate of this bug. ***
WebKit Commit Bot
Comment 7 2025-11-18 09:21:23 PST
Re-opened since this is blocked by bug 302717
Note You need to log in before you can comment on or make changes to this bug.