WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
22763
escape button doesn't close chat window
https://bugs.webkit.org/show_bug.cgi?id=22763
Summary
escape button doesn't close chat window
jasneet
Reported
2008-12-09 14:04:59 PST
I Steps: Login to
http://www.meebo.com/
Click on any contact name to open a chat window Press escape button II Issue: On pressing Escape button, the chat window doesn't close in webkit III Other Browsers: IE7: ok FF3: ok IV Nightly tested: 39088 Bug in Chromium :
http://code.google.com/p/chromium/issues/detail?id=1276
Attachments
Add attachment
proposed patch, testcase, etc.
Christopher M. Balz
Comment 1
2009-07-29 13:06:37 PDT
* Please see:
https://us.etrade.com/javascript/et1/dev_tools/test/harness/modal_dialog/index-developers.html
for a clear, source-code test case showing what seems to be the exact same problem. * As of this date, the issue is still not fixed either in WebKit Version 4.0.2 (4530.19,
r46367
) nor in the Apple Safari 4.0.2. * I have filed a bug on the same issue by using the "Report Bugs to Apple . . . " menu option on the Safari "Safari" web browser menu. Steps ----- What should happen: The 'esc' key should cause a modal dialog window to close. What happens: The 'esc' key has no effect. How to reproduce: a) Visit this page (
https://us.etrade.com/javascript/et1/dev_tools/test/harness/modal_dialog/index-developers.html
). b) Click on the button 'Click Here to Show Modal Dialog". c) Press the 'esc' key d) Verify that the modal dialog does not close. Notes ----- Other Reference Browsers: The 'esc' key works properly on Firefox, Internet Explorer 6 through 8, and Opera. Importance: This bug affects functionality in production on etrade.com. If this is the same bug as the Meebo one, which I think it is, then many users of the very popular Meebo service also do not get the functionality. Version: This issue is in Safari 4.0.2, but the dropdown box does not have that option. So I put it at Safari 528+. The issue is also in the WebKit nightly from yesterday ( Version 4.0.2 (4530.19,
r46367
) ), per my comment above.
Joseph Holsten
Comment 2
2010-01-08 15:55:27 PST
I'm glad you can write a test harness. Unfortunately, I have no idea why you think the escape button should close the chat window. Escape does not normally close a window by default. Are you attaching to a keyboard event?
Christopher M. Balz
Comment 3
2010-01-08 22:40:10 PST
Thank you for responding. I address the issues you raise below: Escape: Escape normally closes a window that is a modal dialog (many examples of this; a handy one is the native JavaScript 'alert' dialog). The test harness shows a modal dialog. I believe the bug that it exposes is the same issue that is affecting the meebo chat window. This has been a WebKit bug for about five years. Attaching to a keyboard event: Yes, the code attempts to detect the keyboard event from the user pressing the 'esc' key, so that it can close the window.
Alexey Proskuryakov
Comment 4
2010-01-12 09:55:59 PST
I suspect that this is a duplicate of
bug 18157
and/or
bug 25147
- we don't dispatch keypress event for the Esc key. One can use keydown for a workaround.
Christopher M. Balz
Comment 5
2010-01-12 14:24:36 PST
Yes, if the browser is not dispatching an event for the keypress event, that would cause this issue.
Alexey Proskuryakov
Comment 6
2014-03-10 09:25:33 PDT
As of today, WebKit dispatches a keypress for Esc. However, this particular bug became invalid: 1. meebo.com no longer exists. 2. The etrade.com test case still doesn't work, however appears to have changed. The pop-up window doesn't install any event handlers any more.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug