RESOLVED FIXED 23709
Fix a callsite of Frame::adjustPageHeight in FrameChromium.cpp 
https://bugs.webkit.org/show_bug.cgi?id=23709
Summary Fix a callsite of Frame::adjustPageHeight in FrameChromium.cpp
Eric Roman
Reported 2009-02-03 11:58:41 PST
FrameChromium.cpp references Frame::adjustPageHeight, which as of r40473 has been moved to FrameView::adjustPageHeight.
Attachments
Update Frame::adjustPageHeight callsite to FrameView::adjustPageHeight (1.36 KB, patch)
2009-02-03 11:59 PST, Eric Roman 		zecke: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Roman
Comment 1 2009-02-03 11:59:40 PST
Created attachment 27283 [details] Update Frame::adjustPageHeight callsite to FrameView::adjustPageHeight
Holger Freyther
Comment 2 2009-02-03 12:51:59 PST
Comment on attachment 27283 [details] Update Frame::adjustPageHeight callsite to FrameView::adjustPageHeight yes, and the view is already null checked.
Holger Freyther
Comment 3 2009-02-03 13:01:29 PST
Landed in r40545 but why isn't PrintContext::computePageRects used?
Eric Roman
Comment 4 2009-02-03 13:49:55 PST
Thanks for the review + check-in! > but why isn't PrintContext::computePageRects used? That's a good question. Marc-Antoine: do you know why we have duplicated this code (it is basically the same as page/PrintContext.cpp)?
Marc-Antoine Ruel
Comment 5 2009-02-03 20:50:10 PST
Simply because it wasn't existing last year and I had to extract the function because it was mixed with code we couldn't use (don't 100% remember). We should remove the duplicate code.
Note You need to log in before you can comment on or make changes to this bug.