WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
268107
[ews] unit-tests should not talk to live github server
https://bugs.webkit.org/show_bug.cgi?id=268107
Summary
[ews] unit-tests should not talk to live github server
Aakash Jain
Reported
2024-01-25 14:43:08 PST
[ews] unit-tests should not talk to live github server. Some unit-test (e.g.: TestAnalyzeCompileWebKitResults) randomly fail because of trying to talk to live GitHub server.
Attachments
Add attachment
proposed patch, testcase, etc.
Aakash Jain
Comment 1
2024-01-25 14:47:50 PST
Example of failure (locally): FAIL: test_pull_request_with_build_failure (ews-build.steps_unittest.TestAnalyzeCompileWebKitResults) test_pull_request_with_build_failure ---------------------------------------------------------------------- Traceback (most recent call last): File "Library/Python/3.9/lib/python/site-packages/twisted/internet/defer.py", line 206, in maybeDeferred result = f(*args, **kwargs) File "Library/Python/3.9/lib/python/site-packages/twisted/internet/utils.py", line 227, in runWithWarningsSuppressed raise exc_info[1].with_traceback(exc_info[2]) File "Library/Python/3.9/lib/python/site-packages/twisted/internet/utils.py", line 223, in runWithWarningsSuppressed result = f(*a, **kw) File "OpenSource/Tools/CISupport/ews-build/steps_unittest.py", line 1393, in test_pull_request_with_build_failure self.assertEqual(self.getProperty('build_finish_summary'), 'Hash 7496f8ec for PR 1234 does not build') File "Library/Python/3.9/lib/python/site-packages/twisted/trial/_synctest.py", line 441, in assertEqual super().assertEqual(first, second, msg) File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/unittest/case.py", line 831, in assertEqual assertion_func(first, second, msg=msg) File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/unittest/case.py", line 824, in _baseAssertEqual raise self.failureException(msg) twisted.trial.unittest.FailTest: None != 'Hash 7496f8ec for PR 1234 does not build'
Aakash Jain
Comment 2
2024-01-25 14:50:32 PST
Pull request:
https://github.com/WebKit/WebKit/pull/23259
EWS
Comment 3
2024-01-25 15:09:13 PST
Committed
273537@main
(5a6af29b4230): <
https://commits.webkit.org/273537@main
> Reviewed commits have been landed. Closing PR #23259 and removing active labels.
Radar WebKit Bug Importer
Comment 4
2024-01-25 15:10:22 PST
<
rdar://problem/121626143
>
EWS
Comment 5
2024-01-25 18:08:47 PST
Committed
272448.380@safari-7618-branch
(aa90a2594f3f): <
https://commits.webkit.org/272448.380@safari-7618-branch
> Reviewed commits have been landed. Closing PR #1040 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug