RESOLVED FIXED270162
Simplify compiler flags checking in Source/ThirdParty/skia/CMakeLists.txt 
https://bugs.webkit.org/show_bug.cgi?id=270162
Summary Simplify compiler flags checking in Source/ThirdParty/skia/CMakeLists.txt
Adrian Perez
Reported 2024-02-27 06:17:58 PST
The CMakeLists.txt looks a bit gnarly around the checks for supported compiler flags. There could be some helpers in WebKitCompilerFlags.cmake, and most of the needed logic is already there but not in a way that can be conveniently reused for the Skia build definitions.
Attachments
Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2024-02-27 06:40:30 PST
Pull request: https://github.com/WebKit/WebKit/pull/25169
EWS
Comment 2 2024-02-27 23:56:44 PST
Committed 275430@main (e739d6576a59): <https://commits.webkit.org/275430@main> Reviewed commits have been landed. Closing PR #25169 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.