RESOLVED FIXED271716
Port.default_child_processes is totally ignored for second-and-later device_types, even when zero 
https://bugs.webkit.org/show_bug.cgi?id=271716
Summary Port.default_child_processes is totally ignored for second-and-later device_t...
Sam Sneddon [:gsnedders]
Reported 2024-03-26 11:11:39 PDT
After bug 261175, 267745@main, due to explicitly setting `child_processes_option_value` the minimum value we set self._options.child_processes to is now zero, which means the below conditional can only ever evaluate to True on the first iteration. This is almost certainly unintended.
Attachments
Add attachment proposed patch, testcase, etc.
Sam Sneddon [:gsnedders]
Comment 1 2024-03-26 12:06:33 PDT
I guess this only actually has broken anything when Port.default_child_processes() is zero and Port.max_child_processes() is not, which I think never actually happens for any existing Port. Regardless, it adds very much a confusing edge-case in our code flow, and the comment is misleading: it has no impact on retries (we already hardcoded num_workers=1 in _run_test_subset).
Sam Sneddon [:gsnedders]
Comment 2 2024-03-26 12:23:38 PDT
Pull request: https://github.com/WebKit/WebKit/pull/26475
Radar WebKit Bug Importer
Comment 3 2024-04-02 11:12:14 PDT
<rdar://problem/125793341>
EWS
Comment 4 2024-04-19 13:13:15 PDT
Committed 277755@main (0de43f2ad98a): <https://commits.webkit.org/277755@main> Reviewed commits have been landed. Closing PR #26475 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.