RESOLVED FIXED277234
http/tests/canvas/ctx.2d-canvas-style-no-document-leak.html is flaky failure 
https://bugs.webkit.org/show_bug.cgi?id=277234
Summary http/tests/canvas/ctx.2d-canvas-style-no-document-leak.html is flaky failure
Fujii Hironori
Reported 2024-07-28 12:55:53 PDT
http/tests/canvas/ctx.2d-canvas-style-no-document-leak.html is flaky failure History: https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fcanvas%2Fctx.2d-canvas-style-no-document-leak.html Buildbot: builder Apple-Sonoma-Release-WK2-Tests build 2831 : 278780@main https://build.webkit.org/#/builders/926/builds/2831 https://build.webkit.org/results/Apple-Sonoma-Release-WK2-Tests/278780@main%20(2831)/http/tests/canvas/ctx.2d-canvas-style-no-document-leak-diff.txt --- /Volumes/Data/worker/Apple-Sonoma-Release-WK2-Tests/build/layout-test-results/http/tests/canvas/ctx.2d-canvas-style-no-document-leak-expected.txt +++ /Volumes/Data/worker/Apple-Sonoma-Release-WK2-Tests/build/layout-test-results/http/tests/canvas/ctx.2d-canvas-style-no-document-leak-actual.txt @@ -6,7 +6,7 @@ PASS internals.isDocumentAlive(frameDocumentID) is true PASS internals.isDocumentAlive(frameDocumentID) is true PASS internals.isDocumentAlive(frameDocumentID) is true -PASS The iframe document didn't leak. +FAIL The iframe document leaked. PASS successfullyParsed is true TEST COMPLETE
Attachments
Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2024-07-28 12:58:43 PDT
This test was added by 263774@main.
Fujii Hironori
Comment 2 2024-07-28 13:29:29 PDT
This test case has only a single iframe. It should create more iframes like document-leak-test.js does.
Ryan Reno
Comment 3 2024-07-29 08:26:17 PDT
Yes, this test should be rewritten to use the document-leak-test.js helper. I'll put a patch up for review shortly. Thanks for catching that. There's a couple of other tests I can rewrite - the one for ReportingObserver callbacks (which is where document-leak-test.js was adopted from), geolocation callbacks, and probably the one for MediaSession Action Handlers.
Radar WebKit Bug Importer
Comment 4 2024-07-29 08:44:05 PDT
<rdar://problem/132725257>
Ryan Reno
Comment 5 2024-07-29 08:49:09 PDT
Pull request: https://github.com/WebKit/WebKit/pull/31395
EWS
Comment 6 2024-07-29 14:12:56 PDT
Committed 281523@main (148e56013b45): <https://commits.webkit.org/281523@main> Reviewed commits have been landed. Closing PR #31395 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.