CLOSED FIXED 3320
REGRESSION (412+): I cannot drag URLs from the location bar of Safari 
https://bugs.webkit.org/show_bug.cgi?id=3320
Summary REGRESSION (412+): I cannot drag URLs from the location bar of Safari
Boyd Waters
Reported 2005-06-07 16:31:30 PDT
Just built the WebKit with the XCode 2.1 work-arounds on Tiger, and I am able to launch Safari with the new WebKit. But now I cannot drag URLs from the location bar of Safari to (for example) the Finder. With the previous WebKit, I was able to drag URLs to the Finder to save "webloc" files. Each time I attempt to drag a URL from the location bar icon (the favicon), a message is printed to the console: 2005-06-07 17:04:01.570 Safari[7622] *** -[NSCFArray addObject:]: attempt to insert nil 2005-06-07 17:04:40.611 Safari[7622] *** -[NSCFArray addObject:]: attempt to insert nil 2005-06-07 17:04:43.172 Safari[7622] *** -[NSCFArray addObject:]: attempt to insert nil 2005-06-07 17:04:57.394 Safari[7622] *** -[NSCFArray addObject:]: attempt to insert nil 2005-06-07 17:05:01.326 Safari[7622] *** -[NSCFArray addObject:]: attempt to insert nil
Attachments
Mac os (11.14 KB, text/html)
2007-05-09 14:00 PDT, Myrtle H. Darnell 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2005-06-07 16:35:11 PDT
Looks like a problem with initialization in WebNSPasteboardExtras.m. Not sure why we didn't ever see this before.
John Sullivan
Comment 2 2005-06-07 16:39:01 PDT
I can reproduce this with locally built WebKit, but not with 10.4.1. Will fix.
John Sullivan
Comment 3 2005-06-07 17:14:29 PDT
Darin thought this was caused by the fact that the code that sets up WebURLPboardType and WebURLNamePboardType is implemented in an +initialize method in a category (NSPasteboard, in WebNSPasteboardExtras.m). But that's not the cause of the bug; I moved the code to a function and verified that the function is called, but the values returned by UTTypeCopyPreferredTagWithClass are both nil.
John Sullivan
Comment 4 2005-06-07 17:25:20 PDT
It seems that this broke during the big SPI conversion prior to releasing WebKit as open source. We must no longer be doing something that we used to do that made UTTypeCopyPreferredTagWithClass return a non-NULL value. I have no idea what this is, so I'm sending this to poor Maciej.
Mark Rowe (bdash)
Comment 5 2005-06-10 02:26:47 PDT
*** Bug 3410 has been marked as a duplicate of this bug. ***
Darin Adler
Comment 6 2005-06-10 15:53:26 PDT
This was caused when Maciej got rid of some deprecated code and tried to use the new API. See <rdar://problem/3446192> CoreTranslation SPI is going away for some details.
John Sullivan
Comment 7 2005-06-10 16:14:55 PDT
*** Bug 3376 has been marked as a duplicate of this bug. ***
John Sullivan
Comment 8 2005-06-10 16:15:53 PDT
This was a problem with WebKitSystemInterface. I've got a fix that I'll check in soon.
John Sullivan
Comment 9 2005-06-10 18:03:05 PDT
Checked in a fix, which involved changes to both libWebKitSystemInterface and WebKit.
Chris Petersen
Comment 10 2005-06-10 19:45:34 PDT
This is fixed with the latest TOT webkit. Reporter, please update to latest webkit and verify this is fixed.
Boyd Waters
Comment 11 2005-06-11 07:57:50 PDT
OK, this bug is resolved... ( although this morning's build pull from CVS, has some sort of debug-mode enabled, renders everything with a blue box drawn around it...)
Myrtle H. Darnell
Comment 12 2007-05-09 14:00:53 PDT
Created attachment 14443 [details] Mac os
Note You need to log in before you can comment on or make changes to this bug.