WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
76725
[Regression] 2% Page Cycler Moz regression
https://bugs.webkit.org/show_bug.cgi?id=76725
Summary
[Regression] 2% Page Cycler Moz regression
Adam Barth
Reported
2012-01-20 12:08:27 PST
Looks to be something in this range:
http://trac.webkit.org/log/trunk/Source?rev=105427&stop_rev=105419&verbose=on
http://build.chromium.org/f/chromium/perf/xp-release-dual-core/moz/report.html?history=150&rev=118458&graph=times
Attachments
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2012-01-20 12:08:48 PST
http://code.google.com/p/chromium/issues/detail?id=110915
Adam Barth
Comment 2
2012-01-20 12:12:07 PST
These two look like the leading candidate for causing the regression:
http://trac.webkit.org/changeset/105426/trunk/Source
http://trac.webkit.org/changeset/105423/trunk/Source
Adam Barth
Comment 3
2012-01-20 12:13:13 PST
I think we should try rolling out
http://trac.webkit.org/changeset/105426
because the ChangeLog mentions there's a risk of a perf regression.
Adam Barth
Comment 4
2012-01-20 12:23:27 PST
Tried reverting 105426 in
http://trac.webkit.org/changeset/105532
Adam Barth
Comment 5
2012-01-20 16:38:44 PST
Reverting that patch seems to have fixed the regression.
http://build.chromium.org/f/chromium/perf/vista-release-webkit-latest/moz/report.html?history=150&rev=-1
Mihnea Ovidenie
Comment 6
2012-01-22 00:03:15 PST
This is huge regression. In my tests, i have never had a regression of this scale. The initial regression introduced by the first version of the region styling patch was 2-3%. I am puzzled but i will try to take a look again at the problem.
Tony Chang
Comment 7
2012-01-22 09:14:29 PST
I think abarth just read the graph wrong. It's about 2%, like before.
Adam Barth
Comment 8
2012-01-22 11:17:18 PST
Sorry, I was just repeating what the performance sheriff wrote.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug