WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
80139
Revert SVG-related APIs from DOMWindowSVG.idl back to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=80139
Summary
Revert SVG-related APIs from DOMWindowSVG.idl back to DOMWindow.idl
Kentaro Hara
Reported
2012-03-02 03:41:42 PST
Based on the discussion on webkit-dev@ (
http://markmail.org/message/kagvswmah67zmrry#query:+page:1+mid:h34vzbiu5suub3ld+state:results
), we should revert SVG-related APIs from DOMWindowSVG.idl back to DOMWindow.idl.
Attachments
Patch
(28.82 KB, patch)
2012-03-02 03:44 PST
,
Kentaro Hara
no flags
Details
Formatted Diff
Diff
Patch
(28.86 KB, patch)
2012-03-02 03:59 PST
,
Kentaro Hara
no flags
Details
Formatted Diff
Diff
patch for landing
(28.92 KB, patch)
2012-03-04 16:54 PST
,
Kentaro Hara
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Kentaro Hara
Comment 1
2012-03-02 03:44:05 PST
Created
attachment 129867
[details]
Patch
Kentaro Hara
Comment 2
2012-03-02 03:59:31 PST
Created
attachment 129870
[details]
Patch
Adam Barth
Comment 3
2012-03-02 09:12:00 PST
Comment on
attachment 129870
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=129870&action=review
> Source/WebCore/page/DOMWindow.idl:495 > + attribute SVGZoomEventConstructor SVGZoomEvent;
This one is outside the ifdef?
Kentaro Hara
Comment 4
2012-03-04 16:54:23 PST
Created
attachment 130034
[details]
patch for landing
Kentaro Hara
Comment 5
2012-03-04 16:54:57 PST
Comment on
attachment 129870
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=129870&action=review
>> Source/WebCore/page/DOMWindow.idl:495 >> + attribute SVGZoomEventConstructor SVGZoomEvent; > > This one is outside the ifdef?
Fixed it and committed. Thanks!
WebKit Review Bot
Comment 6
2012-03-04 18:33:43 PST
Comment on
attachment 130034
[details]
patch for landing Clearing flags on attachment: 130034 Committed
r109693
: <
http://trac.webkit.org/changeset/109693
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug