RESOLVED FIXED 81207
MediaStream API (JSEP): Introducing MediaHints and IceOptions 
https://bugs.webkit.org/show_bug.cgi?id=81207
Summary MediaStream API (JSEP): Introducing MediaHints and IceOptions
Tommy Widenflycht
Reported 2012-03-15 04:24:54 PDT
Introducing the platform MediaHints and IceOptions helper classes.
Attachments
Patch (12.75 KB, patch)
2012-03-15 05:03 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tommy Widenflycht
Comment 1 2012-03-15 05:03:08 PDT
Created attachment 132021 [details] Patch
Adam Barth
Comment 2 2012-03-15 10:59:37 PDT
Comment on attachment 132021 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132021&action=review > Source/WebCore/platform/mediastream/IceOptions.h:55 > + IceOptions(UseCandidatesOption useCandidates) : m_useCandidates(useCandidates) { } One-argument constructors should have the "explicit" keyword.
Adam Barth
Comment 3 2012-03-15 11:00:18 PDT
Comment on attachment 132021 [details] Patch Please consider addressing these nits in a follow-up patch.
WebKit Review Bot
Comment 4 2012-03-15 20:45:46 PDT
Comment on attachment 132021 [details] Patch Clearing flags on attachment: 132021 Committed r110937: <http://trac.webkit.org/changeset/110937>
WebKit Review Bot
Comment 5 2012-03-15 20:45:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.