WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
85657
Default container for horizontal cues
https://bugs.webkit.org/show_bug.cgi?id=85657
Summary
Default container for horizontal cues
Victor Carbune
Reported
2012-05-04 13:27:31 PDT
The default renderer for the text track container should be a flexible box container, such that cues without positioning information are implicitly positioned on top of each other.
Attachments
Implicit positioning
(14.12 KB, text/plain)
2012-05-04 13:43 PDT
,
Victor Carbune
no flags
Details
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Victor Carbune
Comment 1
2012-05-04 13:43:49 PDT
Created
attachment 140311
[details]
Implicit positioning
Eric Carlson
Comment 2
2012-05-07 08:51:01 PDT
Comment on
attachment 140311
[details]
Implicit positioning View in context:
https://bugs.webkit.org/attachment.cgi?id=140311&action=review
> Source/WebCore/html/track/TextTrackCue.cpp:432 > + // If cue is not associated with a text track, return â1 and abort these > + // steps.
Oops, a non-ASCII character snuck in here for "-".
> Source/WebCore/html/track/TextTrackCue.cpp:439 > + // Let n be the number of text tracks whose text track mode is showing or > + // showing by default and that are in the media element's list of text > + // tracks before track. > + int n = track()->trackIndex();
Won't this potentially include HIDDEN and DISABLED tracks? If this doesn't matter, please say why in the comment.
Victor Carbune
Comment 3
2012-06-16 17:42:43 PDT
As per our latest discussions, a default (nested) container is not the right way to implement the current form of the specification.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug