WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
92014
REGRESSION(
r123281
): childNodes sometimes returns wrong nodes
https://bugs.webkit.org/show_bug.cgi?id=92014
Summary
REGRESSION(r123281): childNodes sometimes returns wrong nodes
Ryosuke Niwa
Reported
2012-07-23 11:50:44 PDT
There's a really careless error in DynamicNodeListCacheBase::itemBeforeOrAfter. It's doing firstNode(forward, rootNode(), previous) but it should read firstNode(forward, rootNode(), shouldOnlyIncludeDirectChildren()) instead.
Attachments
Fixes the typo
(4.17 KB, patch)
2012-07-23 11:56 PDT
,
Ryosuke Niwa
no flags
Details
Formatted Diff
Diff
Move the console output to be below 1-5 and test description
(4.21 KB, patch)
2012-07-23 11:59 PDT
,
Ryosuke Niwa
andersca
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2012-07-23 11:56:06 PDT
Created
attachment 153825
[details]
Fixes the typo
Ryosuke Niwa
Comment 2
2012-07-23 11:59:16 PDT
Created
attachment 153827
[details]
Move the console output to be below 1-5 and test description
Ryosuke Niwa
Comment 3
2012-07-23 12:26:46 PDT
Committed
r123359
: <
http://trac.webkit.org/changeset/123359
>
Ryosuke Niwa
Comment 4
2012-07-23 13:41:46 PDT
http://crbug.com/138488
Ryosuke Niwa
Comment 5
2012-07-23 13:42:57 PDT
***
Bug 91980
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug