RESOLVED FIXED 95260
Handle sticky that overflows its container 
https://bugs.webkit.org/show_bug.cgi?id=95260
Summary Handle sticky that overflows its container
Simon Fraser (smfr)
Reported 2012-08-28 16:21:08 PDT
Handle sticky that overflows its container
Attachments
Patch (8.96 KB, patch)
2012-08-28 16:28 PDT, Simon Fraser (smfr) 		ojan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2012-08-28 16:28:53 PDT
Created attachment 161085 [details] Patch
Ojan Vafai
Comment 2 2012-08-28 17:00:56 PDT
Comment on attachment 161085 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161085&action=review Seems reasonable. It's hard to evaluate whether this really makes sense since I can't think of use-cases, but this is clearly an improvement IMO. > LayoutTests/fast/css/sticky/sticky-overflowing.html:8 > + height: 2000px; It's annoying, but our reftesting infrastructure still only does 800x600 pixel dumps, so anything below the 600th pixel won't actually get tested. We should probably fix this eventually, but I think it requires lots of plubming (e.g. modifying each DRT to be able to dump the whole image). > LayoutTests/fast/css/sticky/sticky-overflowing.html:68 > + A<br> > + A<br> > + A<br> > + A<br> > + A<br> > + A<br> > + A<br> > + A<br> > + A<br> > + A<br> > + A<br> > + A<br> > + A<br> This is fine, but you could also just use a single div with a fixed height/width.
Simon Fraser (smfr)
Comment 3 2012-08-28 17:02:04 PDT
(In reply to comment #2) > (From update of attachment 161085 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=161085&action=review > > Seems reasonable. It's hard to evaluate whether this really makes sense since I can't think of use-cases, but this is clearly an improvement IMO. > > > LayoutTests/fast/css/sticky/sticky-overflowing.html:8 > > + height: 2000px; > > It's annoying, but our reftesting infrastructure still only does 800x600 pixel dumps, so anything below the 600th pixel won't actually get tested. We should probably fix this eventually, but I think it requires lots of plubming (e.g. modifying each DRT to be able to dump the whole image). That height was only so I could scroll while testing. The interesting part of the image is within the 800x600 rectangle. > > LayoutTests/fast/css/sticky/sticky-overflowing.html:68 > > + A<br> > > + A<br> > > + A<br> > > + A<br> > > + A<br> > > + A<br> > > + A<br> > > + A<br> > > + A<br> > > + A<br> > > + A<br> > > + A<br> > > + A<br> > > This is fine, but you could also just use a single div with a fixed height/width. I could!
Simon Fraser (smfr)
Comment 4 2012-08-28 17:38:36 PDT
http://trac.webkit.org/changeset/126943
Simon Fraser (smfr)
Comment 5 2012-09-07 10:01:29 PDT
*** Bug 94991 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.